raghavyadav01 commented on code in PR #16478:
URL: https://github.com/apache/pinot/pull/16478#discussion_r2246494804
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java:
##########
@@ -107,24 +106,12 @@ public BaseFilterOperator
getLeafFilterOperator(QueryContext queryContext, Predi
}
return new ScanBasedFilterOperator(queryContext, predicateEvaluator,
dataSource, numDocs);
} else if (predicateType == Predicate.Type.REGEXP_LIKE) {
- // Check if case-insensitive flag is present
- RegexpLikePredicate regexpLikePredicate = (RegexpLikePredicate)
predicateEvaluator.getPredicate();
- boolean caseInsensitive = regexpLikePredicate.isCaseInsensitive();
- if (caseInsensitive) {
- if (dataSource.getIFSTIndex() != null &&
dataSource.getDataSourceMetadata().isSorted()
+ if (predicateEvaluator instanceof
BaseDictIdBasedRegexpLikePredicateEvaluator) {
Review Comment:
Don't we need to check if IFST/FST index is not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
