arunkumarucet commented on code in PR #16497: URL: https://github.com/apache/pinot/pull/16497#discussion_r2260386740
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxStringAggregationFunction.java: ########## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.ObjectAggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.ObjectGroupByResultHolder; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.spi.exception.BadQueryRequestException; + + +public class MaxStringAggregationFunction extends NullableSingleInputAggregationFunction<String, String> { + + public MaxStringAggregationFunction(List<ExpressionContext> arguments, boolean nullHandlingEnabled) { + super(verifySingleArgument(arguments, "MAXSTRING"), nullHandlingEnabled); + } + + @Override + public AggregationFunctionType getType() { + return AggregationFunctionType.MAXSTRING; + } + + @Override + public AggregationResultHolder createAggregationResultHolder() { + return new ObjectAggregationResultHolder(); + } + + @Override + public GroupByResultHolder createGroupByResultHolder(int initialCapacity, int maxCapacity) { + return new ObjectGroupByResultHolder(initialCapacity, maxCapacity); + } + + @Override + public void aggregate(int length, AggregationResultHolder aggregationResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + BlockValSet blockValSet = blockValSetMap.get(_expression); + if (blockValSet.getValueType().isNumeric()) { + throw new BadQueryRequestException("Cannot compute MAXSTRING for numeric column: " + + blockValSet.getValueType()); + } + String[] stringValues = blockValSet.getStringValuesSV(); + String maxValue = foldNotNull(length, blockValSet, null, (acum, from, to) -> { + String innerMax = stringValues[from]; + for (int i = from + 1; i < to; i++) { + if (stringValues[i].compareTo(innerMax) > 0) { + innerMax = stringValues[i]; + } + } + return acum == null ? innerMax : (acum.compareTo(innerMax) > 0 ? acum : innerMax); + }); + + String currentMax = aggregationResultHolder.getResult(); + if (currentMax == null || (maxValue != null && maxValue.compareTo(currentMax) > 0)) { + aggregationResultHolder.setValue(maxValue); + } + } + + @Override + public void aggregateGroupBySV(int length, int[] groupKeyArray, GroupByResultHolder groupByResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + BlockValSet blockValSet = blockValSetMap.get(_expression); + if (blockValSet.getValueType().isNumeric()) { + throw new BadQueryRequestException("Cannot compute MAXSTRING for numeric column: " + + blockValSet.getValueType()); + } + String[] stringValues = blockValSet.getStringValuesSV(); + forEachNotNull(length, blockValSet, (from, to) -> { + for (int i = from; i < to; i++) { + String value = stringValues[i]; + int groupKey = groupKeyArray[i]; + String currentMax = groupByResultHolder.getResult(groupKey); + if (currentMax == null || value.compareTo(currentMax) > 0) { + groupByResultHolder.setValueForKey(groupKey, value); + } + } + }); + } + + @Override + public void aggregateGroupByMV(int length, int[][] groupKeysArray, GroupByResultHolder groupByResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + BlockValSet blockValSet = blockValSetMap.get(_expression); + if (blockValSet.getValueType().isNumeric()) { + throw new BadQueryRequestException("Cannot compute MAXSTRING for numeric column: " + + blockValSet.getValueType()); + } + String[] stringValues = blockValSet.getStringValuesSV(); + forEachNotNull(length, blockValSet, (from, to) -> { + for (int i = from; i < to; i++) { + String value = stringValues[i]; + for (int groupKey : groupKeysArray[i]) { + String currentMax = groupByResultHolder.getResult(groupKey); + if (currentMax == null || value.compareTo(currentMax) > 0) { + groupByResultHolder.setValueForKey(groupKey, value); + } + } + } + }); + } + + @Override + public String extractAggregationResult(AggregationResultHolder aggregationResultHolder) { + return aggregationResultHolder.getResult(); + } + + @Override + public String extractGroupByResult(GroupByResultHolder groupByResultHolder, int groupKey) { + return groupByResultHolder.getResult(groupKey); + } + + @Override + public String merge(String intermediateResult1, String intermediateResult2) { Review Comment: Sure, Added @gortiz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
