lnbest0707-uber commented on code in PR #16492:
URL: https://github.com/apache/pinot/pull/16492#discussion_r2261477127
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -796,9 +796,10 @@ private String createNewSegmentMetadata(TableConfig
tableConfig, IdealState idea
// segment. For tables with pauseless mode enabled, this size is
unavailable at this step because the
// segment has not yet been built.
- createNewSegmentZKMetadata(tableConfig, streamConfigs.get(0),
newLLCSegment, newSegmentCreationTimeMs,
+ createNewSegmentZKMetadataWithOffsetAutoReset(tableConfig,
streamConfigs.get(0), newLLCSegment,
+ newSegmentCreationTimeMs,
committingSegmentDescriptor, committingSegmentZKMetadata,
instancePartitions, partitionIds.size(),
- numReplicas);
+ numReplicas, false);
Review Comment:
My understanding of "prioritise consumption of offset within the SLA" is
that when we have tried to ingest the data, but due to the volume issue, we
cannot catch up with it. Then reset the offset and prioritize the latest
offsets.
But for new partitions/tables, we have not tried it. So we should respect
user's input first till we found we are not able to catch up.
This is not a technical issue, more like how we'd like to design the trigger
condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
