ankitsultana commented on code in PR #16580:
URL: https://github.com/apache/pinot/pull/16580#discussion_r2271165416
##########
pinot-controller/src/main/resources/app/components/Query/TimeseriesQueryPage.tsx:
##########
@@ -560,23 +579,37 @@ const TimeseriesQueryPage = () => {
<SimpleAccordion
headerTitle="Timeseries Chart & Statistics"
showSearchBox={false}
+ detailsContainerClass={classes.timeseriesAccordionDetails}
>
- {truncatedChartSeries.length > 0 ? (
+ {chartSeries.length > 0 ? (
<>
<TruncationWarning
- totalSeries={chartSeries.length}
- truncatedSeries={truncatedChartSeries.length}
+ totalSeries={totalSeriesCount}
+ truncatedSeries={chartSeries.length}
/>
<TimeseriesChart
- series={truncatedChartSeries}
+ series={chartSeries}
height={500}
selectedMetric={selectedMetric}
/>
<MetricStatsTable
- series={truncatedChartSeries}
+ series={chartSeries}
selectedMetric={selectedMetric}
onMetricSelect={setSelectedMetric}
/>
+ <div className={classes.seriesLimitContainer}>
+ <Typography variant="body2" color="textSecondary">
+ Max Series Limit:
Review Comment:
nit: can you call this `Max Series Render Limit`? To avoid confusion with
series limit knobs in the query API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
