xiangfu0 commented on code in PR #16575:
URL: https://github.com/apache/pinot/pull/16575#discussion_r2279913136
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/JsonFunctions.java:
##########
@@ -75,6 +75,25 @@ private JsonFunctions() {
CacheProvider.setCache(new JsonPathCache());
}
+ @ScalarFunction
+ public static String jsonExtractScalar(String jsonString, String jsonPath) {
Review Comment:
The signature of this function should be using the same arguments as the
transform function definition:
```
JSONEXTRACTSCALAR(jsonField, 'jsonPath', 'resultsType', [defaultValue])
```
You can refer to this
doc(https://docs.pinot.apache.org/functions-1/jsonextractscalar
) and the implementation of `JsonExtractScalarTransformFunction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
