Jackie-Jiang commented on code in PR #16603:
URL: https://github.com/apache/pinot/pull/16603#discussion_r2279932728
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/MailboxAssignmentVisitor.java:
##########
@@ -165,8 +165,13 @@ private static boolean
isDirectExchangeCompatible(DispatchablePlanMetadata sende
DispatchablePlanMetadata receiver) {
int numSenders = sender.getWorkerIdToServerInstanceMap().size();
int numReceivers = receiver.getWorkerIdToServerInstanceMap().size();
- return numSenders * sender.getPartitionParallelism() == numReceivers &&
sender.getPartitionFunction() != null
- &&
sender.getPartitionFunction().equalsIgnoreCase(receiver.getPartitionFunction());
+ if (numSenders * sender.getPartitionParallelism() != numReceivers) {
+ return false;
+ }
+ if (sender.getPartitionFunction() == null) {
Review Comment:
Without hint, when sender is pre-partitioned, does it always come with a
partition function? If so, do we need to check receiver partition function?
Let's also add some comment on why we perform this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
