songwdfu opened a new pull request, #16621: URL: https://github.com/apache/pinot/pull/16621
Convert group by query with no order-by, small limit, and no having to safeTrim case by adding order-by of group keys. Ideally, users could adjust `sortAggregateLimitThrshold` knobs for more correct result, and set `sortAggregateSequentialSegmentsThreshold` to use single-threaded combine for minimum mem usage. (Smaller than concurrentHashMap and pair-wise combine) IMO converting queries with HAVING might not be a good idea, since for these queries we may not want to trim segments, and then we don't get the sorted segment results for free. TODO: convert partial order by key as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
