suvodeep-pyne commented on code in PR #16649:
URL: https://github.com/apache/pinot/pull/16649#discussion_r2291714534
##########
pinot-common/src/main/java/org/apache/pinot/common/audit/AuditConfigManager.java:
##########
@@ -32,12 +40,10 @@
* Self-registers with the provided cluster config provider.
*/
@Singleton
-public final class AuditConfigManager {
-
+public final class AuditConfigManager implements ClusterConfigChangeListener {
Review Comment:
The challenge with this approach is that now we might have to refactor this
back to something like pinot-common before pushing the audit log changes. Else,
we duplicate code in the controller and then again the broker. But let me do
this refactor in the next PR given the time crunch with audit log.
The refactor can be an independent PR that should not be affect other
components. thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
