J-HowHuang commented on PR #16455: URL: https://github.com/apache/pinot/pull/16455#issuecomment-3215372011
@yashmayya Thanks for going through these code. > This sounds like a good solution to me, did you have any concerns or misgivings about this approach? Or was https://github.com/apache/pinot/pull/16455#issuecomment-3141200274 made before you implemented the ZK metadata based solution here? Yes that was before I implemented the ZK method. I don't have concerns here. I added a change in `isTableRebalanceJobStuck` to cover one corner case mentioned in [this comment](https://github.com/apache/pinot/pull/16455#discussion_r2294440247), please see if it makes sense. As for the removal of the abstract classes, let's see if @shounakmk219 has any concerns, otherwise I can remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
