lnbest0707-uber commented on code in PR #16494:
URL: https://github.com/apache/pinot/pull/16494#discussion_r2294832628
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2776,54 +2842,4 @@ public List<String> getCommittingSegments(String
realtimeTableName) {
private List<String> getCommittingSegments(String realtimeTableName,
Collection<String> segmentsToCheck) {
return getCommittingSegments(realtimeTableName, segmentsToCheck,
_helixResourceManager::getSegmentZKMetadata);
}
-
- public static List<String> getCommittingSegments(String realtimeTableName,
Review Comment:
The IDE moved the static methods before non-static ones. We do not have
strict enforcement in Pinot styles. If preferred not to be change, I can move
them back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
