tarun11Mavani commented on code in PR #16675:
URL: https://github.com/apache/pinot/pull/16675#discussion_r2295461228
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -210,7 +216,7 @@ public ConfigSuccessResponse addConfig(
}
TableConfigs tableConfigs = tableConfigsAndUnrecognizedProps.getLeft();
String databaseName =
DatabaseUtils.extractDatabaseFromHttpHeaders(httpHeaders);
- validateConfig(tableConfigs, databaseName, typesToSkip);
+ validateConfig(tableConfigs, databaseName, SKIP_CLUSTER_VALIDATIONS);
Review Comment:
If we hardcode this, users will not be able to pass typesToSkip. We should
avoid this change or have a logic to add SKIP_CLUSTER_VALIDATIONS into
typesToSkip before making the call.
IMO we should keep it as is and let it do validation twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
