Jackie-Jiang commented on issue #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table URL: https://github.com/apache/incubator-pinot/pull/4695#issuecomment-542026391 > Can you minimize the changes to the ones you absolutely need? We can do a separate cleanup checkin. Otherwise it gets very hard for reviewers @mcvsubbu I started that way, but with boolean type return as well as exception inside the method, it becomes really hard to handle unexpected behaviors. Regardless of the changes in tests, most of the changes are in PinotLLCRealtimeSegmentManager because the segment assignment logic needs to be replaced.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
