swaminathanmanish commented on code in PR #16681:
URL: https://github.com/apache/pinot/pull/16681#discussion_r2306515168
##########
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java:
##########
@@ -765,10 +765,10 @@ private void visitFiles(URI fileUri, boolean recursive,
Consumer<S3Object> objec
_s3Client.listObjectsV2(listObjectsV2Request));
LOGGER.debug("Getting ListObjectsV2Response: {}",
listObjectsV2Response);
List<S3Object> filesReturned = listObjectsV2Response.contents();
- filesReturned.forEach(objectVisitor);
+ filesReturned.stream().filter(file ->
!prefix.equals(file.key())).forEach(objectVisitor);
Review Comment:
Is there no equivalent call in s3 to list of files from a directory instead
of we doing the filtering ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
