deepthi912 commented on code in PR #16726:
URL: https://github.com/apache/pinot/pull/16726#discussion_r2316586065
##########
pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java:
##########
@@ -521,6 +575,248 @@ private void
downLoadAndVerifyValidDocIdsSnapshotBitmap(String tableNameWithType
queryableDocIds.getMutableRoaringBitmap());
}
+ @Test
+ public void testValidDocIdsMetadataPostForInMemory()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ List<String> segments = List.of(segment.getSegmentName());
+ TableSegments tableSegments = new TableSegments(segments);
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdsMetadata";
+
+ // Test IN_MEMORY validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType", ValidDocIdsType.IN_MEMORY.toString())
+ .request()
+ .post(Entity.json(tableSegments), String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY");
+
Assert.assertEquals(validDocIdsMetadata.get("segmentSizeInBytes").asLong(),
4514723);
+ Assert.assertTrue(validDocIdsMetadata.has("segmentCreationTimeMillis"));
+
Assert.assertTrue(validDocIdsMetadata.get("segmentCreationTimeMillis").asLong()
> 0);
+
+ // Verify server status information
+ Assert.assertTrue(validDocIdsMetadata.has("serverStatus"), "Server status
should be included in response");
+ String serverStatus = validDocIdsMetadata.get("serverStatus").asText();
+ Assert.assertNotNull(serverStatus, "Server status should not be null");
+ Assert.assertEquals(serverStatus, "NOT_STARTED", serverStatus);
+ }
+
+ @Test
+ public void testValidDocIdsMetadataPostForInMemoryWithDelete()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ List<String> segments = List.of(segment.getSegmentName());
+ TableSegments tableSegments = new TableSegments(segments);
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdsMetadata";
+
+ // Test IN_MEMORY_WITH_DELETE validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType",
ValidDocIdsType.IN_MEMORY_WITH_DELETE.toString())
+ .request()
+ .post(Entity.json(tableSegments), String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY_WITH_DELETE");
+
Assert.assertEquals(validDocIdsMetadata.get("segmentSizeInBytes").asLong(),
4514723);
+ Assert.assertTrue(validDocIdsMetadata.has("segmentCreationTimeMillis"));
+
Assert.assertTrue(validDocIdsMetadata.get("segmentCreationTimeMillis").asLong()
> 0);
+
+ // Verify server status information
+ Assert.assertTrue(validDocIdsMetadata.has("serverStatus"), "Server status
should be included in response");
+ String serverStatus = validDocIdsMetadata.get("serverStatus").asText();
+ Assert.assertNotNull(serverStatus, "Server status should not be null");
+ Assert.assertEquals(serverStatus, "NOT_STARTED", serverStatus);
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForSnapshotWithDelete()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdMetadata";
+
+ // Test GET endpoint with SNAPSHOT_WITH_DELETE validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType",
ValidDocIdsType.SNAPSHOT_WITH_DELETE.toString())
+ .request()
+ .get(String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"SNAPSHOT_WITH_DELETE");
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForInMemory()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdMetadata";
+
+ // Test GET endpoint with IN_MEMORY validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType", ValidDocIdsType.IN_MEMORY.toString())
+ .request()
+ .get(String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY");
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForInMemoryWithDelete()
Review Comment:
Why do we want to add this test case for IN_MEMORY_WITH_DELETE?
##########
pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java:
##########
@@ -521,6 +575,248 @@ private void
downLoadAndVerifyValidDocIdsSnapshotBitmap(String tableNameWithType
queryableDocIds.getMutableRoaringBitmap());
}
+ @Test
+ public void testValidDocIdsMetadataPostForInMemory()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ List<String> segments = List.of(segment.getSegmentName());
+ TableSegments tableSegments = new TableSegments(segments);
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdsMetadata";
+
+ // Test IN_MEMORY validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType", ValidDocIdsType.IN_MEMORY.toString())
+ .request()
+ .post(Entity.json(tableSegments), String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY");
+
Assert.assertEquals(validDocIdsMetadata.get("segmentSizeInBytes").asLong(),
4514723);
+ Assert.assertTrue(validDocIdsMetadata.has("segmentCreationTimeMillis"));
+
Assert.assertTrue(validDocIdsMetadata.get("segmentCreationTimeMillis").asLong()
> 0);
+
+ // Verify server status information
+ Assert.assertTrue(validDocIdsMetadata.has("serverStatus"), "Server status
should be included in response");
+ String serverStatus = validDocIdsMetadata.get("serverStatus").asText();
+ Assert.assertNotNull(serverStatus, "Server status should not be null");
+ Assert.assertEquals(serverStatus, "NOT_STARTED", serverStatus);
+ }
+
+ @Test
+ public void testValidDocIdsMetadataPostForInMemoryWithDelete()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ List<String> segments = List.of(segment.getSegmentName());
+ TableSegments tableSegments = new TableSegments(segments);
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdsMetadata";
+
+ // Test IN_MEMORY_WITH_DELETE validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType",
ValidDocIdsType.IN_MEMORY_WITH_DELETE.toString())
+ .request()
+ .post(Entity.json(tableSegments), String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY_WITH_DELETE");
+
Assert.assertEquals(validDocIdsMetadata.get("segmentSizeInBytes").asLong(),
4514723);
+ Assert.assertTrue(validDocIdsMetadata.has("segmentCreationTimeMillis"));
+
Assert.assertTrue(validDocIdsMetadata.get("segmentCreationTimeMillis").asLong()
> 0);
+
+ // Verify server status information
+ Assert.assertTrue(validDocIdsMetadata.has("serverStatus"), "Server status
should be included in response");
+ String serverStatus = validDocIdsMetadata.get("serverStatus").asText();
+ Assert.assertNotNull(serverStatus, "Server status should not be null");
+ Assert.assertEquals(serverStatus, "NOT_STARTED", serverStatus);
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForSnapshotWithDelete()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdMetadata";
+
+ // Test GET endpoint with SNAPSHOT_WITH_DELETE validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType",
ValidDocIdsType.SNAPSHOT_WITH_DELETE.toString())
+ .request()
+ .get(String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"SNAPSHOT_WITH_DELETE");
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForInMemory()
+ throws IOException {
+ IndexSegment segment = _realtimeIndexSegments.get(0);
+ // Verify the content of the downloaded snapshot from a realtime table.
+
downLoadAndVerifyValidDocIdsSnapshot(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
downLoadAndVerifyValidDocIdsSnapshotBitmap(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME),
+ (ImmutableSegmentImpl) segment);
+
+ String validDocIdsMetadataPath =
+ "/tables/" + TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME) +
"/validDocIdMetadata";
+
+ // Test GET endpoint with IN_MEMORY validDocIdsType
+ String response = _webTarget.path(validDocIdsMetadataPath)
+ .queryParam("segmentNames", segment.getSegmentName())
+ .queryParam("validDocIdsType", ValidDocIdsType.IN_MEMORY.toString())
+ .request()
+ .get(String.class);
+ JsonNode validDocIdsMetadata = JsonUtils.stringToJsonNode(response).get(0);
+
+ Assert.assertEquals(validDocIdsMetadata.get("totalDocs").asInt(), 200000);
+ Assert.assertEquals(validDocIdsMetadata.get("totalValidDocs").asInt(), 8);
+ Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
199992);
+ Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"187068486");
+ Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"IN_MEMORY");
+ }
+
+ @Test
+ public void testValidDocIdsMetadataGetForInMemoryWithDelete()
Review Comment:
Why do we want to add this test case for `IN_MEMORY_WITH_DELETE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
