Copilot commented on code in PR #16741:
URL: https://github.com/apache/pinot/pull/16741#discussion_r2324014132
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -1083,8 +1084,13 @@ public List<SegmentConsumerInfo>
getConsumingSegmentsInfo(
new
SegmentConsumerInfo.PartitionOffsetInfo(partitiionToOffsetMap,
partitionStateMap.entrySet().stream()
.collect(Collectors.toMap(Map.Entry::getKey, e ->
e.getValue().getUpstreamLatestOffset().toString())),
recordsLagMap, availabilityLagMsMap)));
+ throw new ConcurrentModificationException("concurrent modification
is not possible when multiple access on Kafka Consumer");
Review Comment:
This line throws a ConcurrentModificationException unconditionally, which
will always cause the catch block below to execute. This appears to be test
code that was accidentally left in the production code and should be removed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
