ankitsultana commented on code in PR #16769:
URL: https://github.com/apache/pinot/pull/16769#discussion_r2337121567
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReader.java:
##########
@@ -76,4 +76,15 @@ GenericRow next(GenericRow reuse)
*/
void rewind()
throws IOException;
+
+ /**
+ * Get the sorted document IDs if available.
+ * This method is used to retrieve the sorted order of document IDs for
segment creation.
+ *
+ * @return array of sorted document IDs, or null if not available or not
applicable
+ */
+ @Nullable
+ default int[] getSortedDocIds() {
Review Comment:
Yeah semantically I am not sure what this means here. Better to remove
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -356,7 +357,8 @@ public void indexRow(GenericRow row)
}
@Override
- public void indexColumn(String columnName, @Nullable int[] sortedDocIds,
IndexSegment segment)
+ public void indexColumn(String columnName, @Nullable int[] sortedDocIds,
IndexSegment segment,
Review Comment:
nit: can you add a javadoc to explain the role of validDocIds. (and the
behavior when it is null)
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentCreator.java:
##########
@@ -67,7 +68,22 @@ void indexRow(GenericRow row)
* @param sortedDocIds - If not null, then this provides the sorted order of
documents.
* @param segment - Used to get the values of the column.
*/
- void indexColumn(String columnName, @Nullable int[] sortedDocIds,
IndexSegment segment)
+ @Deprecated
Review Comment:
I don't think we need to Deprecate this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
