Copilot commented on code in PR #16810:
URL: https://github.com/apache/pinot/pull/16810#discussion_r2346874107
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -850,8 +850,19 @@ public void run() {
break;
case KEEP: {
if (_segmentCompletionMode == CompletionMode.DOWNLOAD) {
- _state = State.DISCARDED;
- break;
+ // Fetch fresh metadata from ZooKeeper to check if download
URL has been set by another replica
+ String downloadUrl =
_realtimeTableDataManager.fetchZKMetadata(_segmentNameStr).getDownloadUrl();
+ if (StringUtils.isNotEmpty(downloadUrl)) {
+ _segmentLogger.info(
+ "CompletionMode is DOWNLOAD and download URL is
available for segment: {}. URL: {}",
+ _segmentNameStr, downloadUrl);
+ _state = State.DISCARDED;
+ break;
+ } else {
+ _segmentLogger.warn(
+ "CompletionMode is DOWNLOAD but download URL is missing
segment: {}. "
Review Comment:
The error message is missing the word "for" before "segment". It should read
"missing for segment: {}" to be grammatically correct.
```suggestion
"CompletionMode is DOWNLOAD but download URL is
missing for segment: {}. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
