deepthi912 commented on code in PR #16832:
URL: https://github.com/apache/pinot/pull/16832#discussion_r2353468308
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java:
##########
@@ -48,9 +61,39 @@ private RegexpLikePredicateEvaluatorFactory() {
* @return Dictionary based REGEXP_LIKE predicate evaluator
*/
public static BaseDictionaryBasedPredicateEvaluator
newDictionaryBasedEvaluator(
- RegexpLikePredicate regexpLikePredicate, Dictionary dictionary, DataType
dataType) {
+ RegexpLikePredicate regexpLikePredicate, Dictionary dictionary, DataType
dataType,
+ @Nullable QueryContext queryContext) {
Preconditions.checkArgument(dataType.getStoredType() == DataType.STRING,
"Unsupported data type: " + dataType);
- if (dictionary.length() < DICTIONARY_CARDINALITY_THRESHOLD_FOR_SCAN) {
+
+ // 1. If useDictForRegexpLikePredicate is set to true, always use
dictionary
+ if (queryContext != null && queryContext.getQueryOptions() != null) {
Review Comment:
Trying to figure out ways to get the configs from table and cluster configs
which I can use to prioritize the switch, but didn't figure out a way yet and
it's also not so right for the lower level classes having access to instance
configs. @Jackie-Jiang thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
