noob-se7en commented on code in PR #16833:
URL: https://github.com/apache/pinot/pull/16833#discussion_r2354749462
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2541,7 +2549,7 @@ private Set<String>
findConsumingSegmentsOfTopics(IdealState idealState, List<In
Set<String> consumingSegments = new TreeSet<>();
idealState.getRecord().getMapFields().forEach((segmentName,
instanceToStateMap) -> {
LLCSegmentName llcSegmentName = LLCSegmentName.of(segmentName);
- if (llcSegmentName != null && topicIndices.contains(
+ if (llcSegmentName != null && !topicIndices.contains(
Review Comment:
Thanks for these fixes. Ideally these should have been caught by unit tests.
Maybe in new PR we can add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
