Jackie-Jiang commented on code in PR #15062:
URL: https://github.com/apache/pinot/pull/15062#discussion_r2356877004
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java:
##########
@@ -143,12 +144,13 @@ public
BlockingSegmentCompletionFSM(PinotLLCRealtimeSegmentManager segmentManage
_maxTimeAllowedToCommitMs = _startTimeMs + _initialCommitTimeMs;
_controllerVipUrl = segmentCompletionManager.getControllerVipUrl();
- if (segmentMetadata.getStatus() ==
CommonConstants.Segment.Realtime.Status.DONE) {
+ if (segmentMetadata.getStatus() !=
CommonConstants.Segment.Realtime.Status.IN_PROGRESS) {
+ _state = BlockingSegmentCompletionFSMState.COMMITTED;
Review Comment:
This change itself shouldn't modify the logic, but keep the existing logic
in `PauselessSegmentCompletionFSM`. @9aman Can you comment on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
