somandal commented on code in PR #16778:
URL: https://github.com/apache/pinot/pull/16778#discussion_r2334132199
##########
pinot-common/src/main/java/org/apache/pinot/common/config/DefaultClusterConfigChangeHandler.java:
##########
@@ -37,12 +40,12 @@
public class DefaultClusterConfigChangeHandler implements
ClusterConfigChangeListener, PinotClusterConfigProvider {
private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultClusterConfigChangeHandler.class);
- private volatile Map<String, String> _properties;
- private final List<PinotClusterConfigChangeListener>
_clusterConfigChangeListeners;
+ private volatile ImmutableMap<String, String> _properties;
+ private final CopyOnWriteArrayList<PinotClusterConfigChangeListener>
_clusterConfigChangeListeners;
Review Comment:
+1, why is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
