Jackie-Jiang commented on code in PR #16271:
URL: https://github.com/apache/pinot/pull/16271#discussion_r2361213181
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -680,6 +672,15 @@ public void start()
Tracing.getThreadAccountant().getClusterConfigChangeListener());
}
+ SendStatsPredicate sendStatsPredicate =
SendStatsPredicate.create(_serverConf, _helixManager);
Review Comment:
We should not move this behind thread accountant initialization since server
metrics need to be initialized.
cc @priyen-stripe who helped find the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
