Copilot commented on code in PR #16811:
URL: https://github.com/apache/pinot/pull/16811#discussion_r2365157819
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2709,16 +2708,15 @@ public void
repairSegmentsInErrorStateForPauselessConsumption(TableConfig tableC
assert idealStateMap != null;
String aliveServer = pickServerToReingest(idealStateMap.keySet());
if (aliveServer == null) {
- LOGGER.warn("No alive server found to re-ingest segment: {} in
table: {}, skipping re-ingestion", segmentName,
- realtimeTableName);
- continue;
+ LOGGER.warn("No alive server found to re-ingest segment: {} in
table: {}", segmentName, realtimeTableName);
+ return;
Review Comment:
Changing from `continue` to `return` will exit the entire method when no
alive server is found for any segment, preventing re-ingestion attempts for
remaining segments. This should remain as `continue` to skip only the current
segment and process others.
```suggestion
continue;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
