jenniferdai commented on a change in pull request #4716: Package pinot-parquet
and pinot-orc module into pinot-hadoop shaded jar
URL: https://github.com/apache/incubator-pinot/pull/4716#discussion_r336233183
##########
File path: pinot-hadoop/pom.xml
##########
@@ -103,6 +103,28 @@
<version>${project.version}</version>
<classifier>shaded</classifier>
</dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-parquet</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-core</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
Review comment:
are you trying to shade the orc and parquet dependencies? this pr only
shades the google dependency, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
