AlexanderKM commented on PR #16867:
URL: https://github.com/apache/pinot/pull/16867#issuecomment-3321258766
>Is there a way to identify if an IS update is persisted? Currently we
assume the update not persisted when exception is thrown, which caused the
issue. That is the root problem to fix
When encountering this problem and first adding the fix, I was hesitant to
go down this path because I feared with this exception, it is better to just
cleanup completely, since the code is already making the decision to delete
metadata.
But I suppose it could be nice to do something like:
```
catch (Exception e) {
if (idealState contains segment) {
exit successfully;
else {
cleanup metadata;
}
...
}
```
Let me know if you would like that in this PR or not @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
