akshayrai commented on a change in pull request #4723: [TE] put default
settings for subscription YAML
URL: https://github.com/apache/incubator-pinot/pull/4723#discussion_r336692776
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -657,6 +657,10 @@ void updateSubscriptionGroup(ThirdEyePrincipal user, long
oldAlertConfigID, Stri
}
}
}
+
+ if (!properties.containsKey(PROP_CLASS_NAME)) {
Review comment:
The parsing of "DEFAULT_ALERTER_PIPELINE" type to the appropriate class
happens in the translator. So you need to move this inside the translator class.
```
private Map<String, Object> buildAlerterProperties(Map<String, Object>
alertYamlConfigs) {
// By default we assume the subscription pipeline follows
DEFAULT_ALERTER_PIPELINE
alertYamlConfigs.putIfAbsent(PROP_TYPE, "DEFAULT_ALERTER_PIPELINE"); //
ADD here
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
