Jackie-Jiang commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2373751051
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -323,19 +320,21 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
JsonNode request, @Nullable RequesterIdentity requesterIdentity,
RequestContext requestContext,
@Nullable HttpHeaders httpHeaders, AccessControl accessControl)
throws Exception {
- QueryThreadContext.setQueryEngine("sse");
_queryLogger.log(requestId, query);
- //Start instrumentation context. This must not be moved further below
interspersed into the code.
+ String cid = extractClientRequestId(sqlNodeAndOptions);
+ if (cid == null) {
+ cid = Long.toString(requestId);
+ }
String workloadName =
QueryOptionsUtils.getWorkloadName(sqlNodeAndOptions.getOptions());
- _resourceUsageAccountant.setupRunner(QueryThreadContext.getCid(),
ThreadExecutionContext.TaskType.SSE,
- workloadName);
- try {
+ // TODO: Revisit whether we should set deadline here
Review Comment:
Timeout hasn't been resolved at this point. Added some comments explaining
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
