praveenc7 commented on code in PR #16672:
URL: https://github.com/apache/pinot/pull/16672#discussion_r2376935228
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryWorkloadConfigUtils.java:
##########
@@ -211,24 +215,167 @@ public static List<String>
validateQueryWorkloadConfig(QueryWorkloadConfig confi
if (enforcementProfile == null) {
errors.add(prefix + "enforcementProfile cannot be null");
} else {
- if (enforcementProfile.getCpuCostNs() < 0) {
+ long enforcementCpu = enforcementProfile.getCpuCostNs();
+ long enforcementMem = enforcementProfile.getMemoryCostBytes();
+ if (enforcementCpu < 0) {
Review Comment:
The main reason for keeping it < 0 and not <= 0, was to mimic some integ
test for failure (future PR on error propagation). Maybe we can improve those
tests?
Will change it to <=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
