gortiz opened a new pull request, #16899: URL: https://github.com/apache/pinot/pull/16899
We detected some cases where sending mailboxes are not correctly terminated. For example, when a `QueryCancelledException` when `MailboxSendOperator` asks for new blocks, we understand that the receiver side may have been cancelled, so we don't send any new message. That is incorrect because we need to close the GRPC resources (if any). Although we could approach it differently, the proper way to do so is to follow the Closable pattern and close the mailbox once the query finishes. Although BlockExchange already had a close method, it was implemented as a noop. Additionally, there was no clear way to close a SendingMailbox (should we cancel or complete?), so I modified this interface to extend AutoCloseable as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
