Jackie-Jiang commented on code in PR #16872:
URL: https://github.com/apache/pinot/pull/16872#discussion_r2380612015
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##########
@@ -48,16 +48,15 @@ public class MailboxContentObserver implements
StreamObserver<MailboxContent> {
private final MailboxService _mailboxService;
private final StreamObserver<MailboxStatus> _responseObserver;
- private final List<ByteBuffer> _mailboxBuffers;
+ private final List<ByteBuffer> _mailboxBuffers =
Collections.synchronizedList(new ArrayList<>());
Review Comment:
I'm being cautious here since I don't completely understand the gRPC
behavior. Here is what I got from ChatGPT:
<img width="979" height="1016" alt="Screenshot 2025-09-25 at 17 50 46"
src="https://github.com/user-attachments/assets/66966df7-efd4-47a8-b26f-2d43733c99c5";
/>
For the same reason, we might need to define `_mailbox` as `volatile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
