Jackie-Jiang commented on code in PR #16921:
URL: https://github.com/apache/pinot/pull/16921#discussion_r2389925452
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/InvertedIndexAndDictionaryBasedForwardIndexCreator.java:
##########
@@ -280,11 +282,16 @@ private Map<String, String>
createForwardIndexForSVColumn()
writeToForwardIndex(dictionary, context);
// Setup and return the metadata properties to update
- Map<String, String> metadataProperties = new HashMap<>();
- metadataProperties.put(getKeyFor(_columnName, HAS_DICTIONARY),
String.valueOf(_dictionaryEnabled));
- metadataProperties.put(getKeyFor(_columnName, DICTIONARY_ELEMENT_SIZE),
- String.valueOf(_dictionaryEnabled ?
_columnMetadata.getColumnMaxLength() : 0));
- return metadataProperties;
+ if (_dictionaryEnabled) {
+ return Map.of();
Review Comment:
We don't need to update any field because it already has dictionary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
