Jackie-Jiang commented on code in PR #16819:
URL: https://github.com/apache/pinot/pull/16819#discussion_r2408965518
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -1365,4 +1368,8 @@ public List<String> getTimeseriesLanguages() {
.filter(lang -> !lang.isEmpty())
.collect(Collectors.toList());
}
+
+ public boolean getSegmentCompletionGroupCommitEnabled() {
Review Comment:
For `boolean` field, we usually name the method `isXXX()`
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -92,6 +92,9 @@ public class ControllerConf extends PinotConfiguration {
// Consider tierConfigs when assigning new offline segment
public static final String CONTROLLER_ENABLE_TIERED_SEGMENT_ASSIGNMENT =
"controller.segment.enableTieredAssignment";
+ // Used to determine whether to use group commit idealstate on segment
completion
+ public static final String
CONTROLLER_SEGMENT_COMPLETION_GROUP_COMMIT_ENABLED =
Review Comment:
We tend to make the default `false` for boolean field. Maybe rename it to
`CONTROLLER_DISABLE_IDEAL_STATE_GROUP_COMMIT`?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1316,7 +1318,13 @@ IdealState updateIdealStateOnSegmentCompletion(String
realtimeTableName, String
updateInstanceStatesForNewConsumingSegment(idealState.getRecord().getMapFields(),
committingSegmentName,
isTablePaused(idealState) ? null : newSegmentName,
segmentAssignment, instancePartitionsMap);
return idealState;
- }, DEFAULT_RETRY_POLICY);
+ };
+ if (_controllerConf.getSegmentCompletionGroupCommitEnabled()) {
Review Comment:
+1 one @ankitsultana's comment. Should we consider integrate this into the
`HelixHelper` so that all updates follow the same mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
