Copilot commented on code in PR #16990:
URL: https://github.com/apache/pinot/pull/16990#discussion_r2417670629
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/QueryRunnerTestBase.java:
##########
@@ -318,8 +321,8 @@ protected static Object canonicalizeValue(ColumnDataType
columnDataType, Object
throw new RuntimeException(e);
}
}
- assertTrue(value instanceof int[],
- "Got unexpected value type: " + value.getClass() + " for INT_ARRAY
column, expected: int[] or JdbcArray");
+ assertTrue(value instanceof int[] || value instanceof List, "Got
unexpected value type: " + value.getClass()
+ + " for INT_ARRAY column, expected: int[], List, or JdbcArray");
Review Comment:
The assertion message should be updated to reflect that `JdbcArray` is also
handled earlier in the method, making the current message misleading about the
complete set of expected types.
```suggestion
+ " for INT_ARRAY column, expected: int[] or List (JdbcArray is
handled above)");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
