yashmayya commented on code in PR #17008:
URL: https://github.com/apache/pinot/pull/17008#discussion_r2427413608
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -1331,6 +1331,9 @@ private static void
validateStarTreeIndexConfigs(List<StarTreeIndexConfig> starT
String column = columnPair.getColumn();
if (!column.equals(AggregationFunctionColumnPair.STAR)) {
referencedColumns.add(column);
+ } else if (columnPair.getFunctionType() !=
AggregationFunctionType.COUNT) {
+ throw new IllegalStateException("Non-COUNT function set the column
as '*' in the functionColumnPair: "
+ + functionColumnPair + ". Please configure an actual column
for the function");
Review Comment:
Do we need a similar validation for the `aggregationConfigs` way of
configuring star-tree indexes (`StarTreeAggregationConfig`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
