somandal opened a new pull request, #17028:
URL: https://github.com/apache/pinot/pull/17028

   This PR adds the following support:
   
   - Support to skip adding star-tree indexes if adding them fails due to 
invalid config. The segment build can still go through
   - Support to handle rolling back to the existing star-tree index if update 
fails
   
   This PR won't skip star-tree index creation in all cases, as we need to 
correctly handle rollback to remove extra files created, or rollback to the 
previous state. If these fail, this can leave the segment in an inconsistent 
state
   
   Testing:
   Added unit tests, did some testing with `HybridQuickstart` as well (and 
checked the segment directories to ensure that the correct changes take effect)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to