gortiz opened a new pull request, #16915: URL: https://github.com/apache/pinot/pull/16915
The current API for SendingMailbox is designed to call `send(Data)` several times, followed by a call to `send(EOS)` and finally a call to `complete()`. At any time, `cancel` can be called to report an uncontrolled error. Having to call `complete` after `send(EOS)` makes no sense and it is error-prone. For example, on https://github.com/apache/pinot/pull/16899 we detected that we were not calling `complete` when using pipeline breaker. This PR changes the code to remove the `complete()` method. Instead, the code executed by that former method is added to `send(EOS)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
