deemoliu commented on code in PR #16852:
URL: https://github.com/apache/pinot/pull/16852#discussion_r2415092172
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -281,14 +290,11 @@ public void updateIngestionMetrics(String segmentName,
int partitionId, long ing
if (v == null) {
// Add metric when we start tracking a partition. Only publish the
metric if supported by the stream.
if (ingestionTimeMs > 0) {
- _serverMetrics.setOrUpdatePartitionGauge(_metricName, partitionId,
ServerGauge.REALTIME_INGESTION_DELAY_MS,
- () -> getPartitionIngestionDelayMs(partitionId));
- }
- if (firstStreamIngestionTimeMs > 0) {
Review Comment:
`if (firstStreamIngestionTimeMs > 0)`
what does this check used for? do we still need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
