rohityadav1993 commented on code in PR #16727: URL: https://github.com/apache/pinot/pull/16727#discussion_r2468689810
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnReaderFactory.java: ########## @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.readers; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.pinot.segment.spi.IndexSegment; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.readers.ColumnReader; +import org.apache.pinot.spi.data.readers.ColumnReaderFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * ColumnReaderFactory implementation for immutable Pinot segments. + * + * <p>This factory creates ColumnReader instances for reading data from Pinot segments + * in a columnar fashion. It handles: + * <ul> + * <li>Creating readers for existing columns in the segment</li> + * <li>Creating default value readers for new columns</li> + * <li>Resource management for all created readers</li> + * </ul> + */ +public class PinotSegmentColumnReaderFactory implements ColumnReaderFactory { Review Comment: Revisited the interface for ColumnReaderFactory. There will be no create* methods exposed. The getMethods will return cached Readers and in future if needed one can add create methods if every time a new object needs to be created from the Factory. Same documentation in the interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
