xiangfu0 commented on code in PR #17144:
URL: https://github.com/apache/pinot/pull/17144#discussion_r2496374870
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2528,6 +2528,18 @@ public PauseState resumeTopicsConsumption(String
tableNameWithType, List<Integer
}
private void sendForceCommitMessageToServers(String tableNameWithType,
Set<String> consumingSegments) {
+ // For partial upsert tables, force-committing consuming segments is
disabled.
+ // In some cases (especially when replication > 1), the server with fewer
consumed rows
+ // was incorrectly chosen as the winner, causing other servers to
reconsume rows
+ // and leading to inconsistent data.
+ // TODO: Temporarily disabled until a proper fix is implemented.
+ TableConfig tableConfig =
_helixResourceManager.getTableConfig(tableNameWithType);
Review Comment:
Worth make this a helper method in TableConfigUtils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
