Copilot commented on code in PR #17156:
URL: https://github.com/apache/pinot/pull/17156#discussion_r2502154298
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java:
##########
@@ -557,6 +557,92 @@ public void testDoubleArrayLiteral(boolean
useMultiStageQueryEngine)
}
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testArraysOverlapWithLiterals(boolean useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+
+ // INT array literals
+ JsonNode result = postQuery("SELECT ARRAYS_OVERLAP(ARRAY[1,2],
ARRAY[3,2])").get("resultTable");
+ assertTrue(result.get("rows").get(0).get(0).asBoolean());
+ result = postQuery("SELECT ARRAYS_OVERLAP(ARRAY[1,2],
ARRAY[3,4])").get("resultTable");
+ assertFalse(result.get("rows").get(0).get(0).asBoolean());
+
+ // LONG array literals (use large values to ensure LONG_ARRAY typing)
Review Comment:
[nitpick] The comment should clarify *why* large values ensure LONG_ARRAY
typing (e.g., 'values exceed INT_MAX to force LONG_ARRAY type inference')
rather than just stating that they do.
```suggestion
// LONG array literals (values exceed INT_MAX [2,147,483,647] to force
LONG_ARRAY type inference)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
