suvodeep-pyne commented on code in PR #17159:
URL: https://github.com/apache/pinot/pull/17159#discussion_r2505739439
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/ServerReloadJobStatusCacheConfig.java:
##########
@@ -18,12 +18,20 @@
*/
package org.apache.pinot.segment.local.utils;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonProperty;
+
/**
* Configuration for ReloadJobStatusCache.
+ * Uses Jackson annotations for automatic JSON mapping from
ClusterConfiguration.
*/
+@JsonIgnoreProperties(ignoreUnknown = true)
public class ServerReloadJobStatusCacheConfig {
+ @JsonProperty("size.max")
Review Comment:
Pinot configs are generally hierarchical. Therefore,
`pinot.server.table.reload.status.cache.size.max` seemed preferable to
`pinot.server.table.reload.status.cache.max.size`.
Similarly from code perspective, `getMaxSize()` or setMaxSize()` seemed more
natural than `getSizeMax()`. The mapping on the member should be clear enough
to address the connection. no?
Q: What is the motivation for this comment? Do you think this can be
confusing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
