tarun11Mavani commented on code in PR #17249:
URL: https://github.com/apache/pinot/pull/17249#discussion_r2548622078
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -438,10 +442,10 @@ protected void
replaceSegmentIfCrcMismatch(SegmentDataManager segmentDataManager
_logger.info("Segment: {} has CRC: {} same as before, not replacing it",
segmentName, localMetadata.getCrc());
return;
}
- if (!_instanceDataManagerConfig.shouldCheckCRCOnSegmentLoad()) {
+ if (!_instanceDataManagerConfig.shouldCheckCRCOnSegmentLoad() ||
_skipCrcCheckForThisTable) {
Review Comment:
Can we use Enablement enum instead of plain boolean? This will allow us to
check if this config is explicitly set via table config and will allow us to
override the instance level config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
