gortiz opened a new pull request, #17263: URL: https://github.com/apache/pinot/pull/17263
This PR improves the visualization tab for MSE queries, splitting the panel vertically. The left side is the same graph we had before, while the right side shows a new flamegraph. There are multiple resources online explaining flamegraph (ie, https://signoz.io/blog/flamegraphs/), but the idea is that they create a structure where the vertical axis represents different phases of a call (in our case, operators) while the horizontal axis represents proportional value. Current state: - Two modes: Clock time and allocation - The flamegraph is divided by stages. This is the best way I found to represent the stats in a flamegraph format, given that the stage boundary breaks some invariants (ie, upstream stage 2 may allocate more than downstream stage 1). - The tooltip of each entry in the flamegraph is just the JSON stats of the operator. - When the mouse hovers MAILBOX_SEND nodes, the receiving stage is highlighted. - When the mouse hovers `Stage X` nodes, the sending stage is highlighted. Things we should improve: - Add proper tooltips - Interconnect the flamegraph and the graph. For example, when zooming in on an operator/stage in the flamegraph, the graph could be refocused on that specific operator/stage. Or when the mouse hovers over a node in the graph, that same stage/operator could be highlighted. - Add search functionality. - Add other diagrams for other non-incremental important stats like emitted rows - Add GC time as mode in case it is supported -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
