Jackie-Jiang commented on code in PR #17243:
URL: https://github.com/apache/pinot/pull/17243#discussion_r2566646524
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -1129,6 +1132,17 @@ public boolean
isAutoResetErrorSegmentsOnValidationEnabled() {
return
getProperty(ControllerPeriodicTasksConf.AUTO_RESET_ERROR_SEGMENTS_VALIDATION,
true);
}
+ public DisasterRecoveryMode getDisasterRecoveryMode() {
+ return
getDisasterRecoveryMode(getProperty(ControllerPeriodicTasksConf.DISASTER_RECOVERY_MODE_CONFIG_KEY));
+ }
+
+ public static DisasterRecoveryMode getDisasterRecoveryMode(@Nullable String
disasterRecoveryModeString) {
Review Comment:
Should it return `DEFAULT` when mode is not explicitly set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
