xiangfu0 commented on code in PR #17308:
URL: https://github.com/apache/pinot/pull/17308#discussion_r2586702319


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -58,6 +59,10 @@ public enum ConsistencyMode {
   @Nullable
   private Map<String, Strategy> _partialUpsertStrategies;
 
+  @JsonPropertyDescription("Transform configs evaluated after partial upsert 
merge to populate derived columns.")
+  @Nullable
+  private List<TransformConfig> _partialUpsertPostUpdateTransformConfigs;

Review Comment:
   Shall we put this here or move it to IngestionConfigs?



##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -58,6 +59,10 @@ public enum ConsistencyMode {
   @Nullable
   private Map<String, Strategy> _partialUpsertStrategies;
 
+  @JsonPropertyDescription("Transform configs evaluated after partial upsert 
merge to populate derived columns.")
+  @Nullable
+  private List<TransformConfig> _partialUpsertPostUpdateTransformConfigs;

Review Comment:
   Shall we put this here or move it to IngestionConfigs?
   cc: @Jackie-Jiang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to