Jackie-Jiang commented on code in PR #17313:
URL: https://github.com/apache/pinot/pull/17313#discussion_r2586717381
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/instance/InstanceDataManagerConfig.java:
##########
@@ -90,4 +90,6 @@ public interface InstanceDataManagerConfig {
boolean isUploadSegmentToDeepStore();
boolean shouldCheckCRCOnSegmentLoad();
+
+ boolean isDimensionTableDisablePreloadEnabled();
Review Comment:
```suggestion
boolean isDimensionTablePreloadDisabled();
```
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##########
@@ -105,6 +105,10 @@ public class HelixInstanceDataManagerConfig implements
InstanceDataManagerConfig
public static final String ENABLE_ASYNC_SEGMENT_REFRESH =
"enable.async.segment.refresh";
private static final boolean DEFAULT_ENABLE_ASYNC_SEGMENT_REFRESH = false;
+ // Whether to disable preloading for dimension tables. Preload Enabled by
default.
+ public static final String DIMENSION_TABLE_DISABLE_PRELOAD =
"dimTable.disablePreload.default";
Review Comment:
```suggestion
public static final String DISABLE_DIMENSION_TABLE_PRELOAD =
"disable.dimension.table.preload";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
