rohityadav1993 commented on issue #17337: URL: https://github.com/apache/pinot/issues/17337#issuecomment-3635390727
> Instead of checking if one of the replicas has zero validDocIds, we should check that all replicas have 0 validDocIds [here](https://github.com/apache/pinot/blob/538407935001e2ffa17fd61a766a41b2bd53f7bc/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java#L313). Checking both replicas for validDocIds to be 0 before selecting for deletion in minion is a quick safety fix. We need to handle the scenario when the other replica is unavailable/restarting, it will be better to skip it rather than select for deletion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
