xiangfu0 commented on code in PR #17324: URL: https://github.com/apache/pinot/pull/17324#discussion_r2612766045
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ########## @@ -54,6 +57,8 @@ public class ConcurrentMapPartitionUpsertMetadataManager extends BasePartitionUp @VisibleForTesting final ConcurrentHashMap<Object, RecordLocation> _primaryKeyToRecordLocationMap = new ConcurrentHashMap<>(); + final ConcurrentHashMap<Object, RecordLocation> _previousKeyToRecordLocationMap = new ConcurrentHashMap<>(); + final Set<Object> _newlyAddedKeys = new HashSet<>(); Review Comment: is this cleared in the success path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
