gortiz commented on code in PR #17327:
URL: https://github.com/apache/pinot/pull/17327#discussion_r2618424161
##########
pom.xml:
##########
@@ -2944,6 +2944,29 @@
</properties>
</configuration>
</plugin>
+ <plugin>
+ <groupId>de.shadowhunt.maven.plugins</groupId>
+ <artifactId>package-info-maven-plugin</artifactId>
+ <version>2.0.0</version>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>package-info</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <packages>
+ <package regex="org.apache.pinot.**">
+ <annotations>
+
<annotation>@javax.annotation.ParametersAreNonnullByDefault</annotation>
+ <annotation>@org.jspecify.annotations.NullMarked</annotation>
+ </annotations>
+ </package>
+ </packages>
+ </configuration>
Review Comment:
Ideally it should be for Pinot devs, but it doesn't work that well with
Intellij. At least my IDE recognizes the annotation when the package-info.java
file is in `src/main/`, but not when it is in `target/generated-sources`.
Probably that is either a bug in the IDE or something we are doing strangely
during packaging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
