abhishekbafna commented on code in PR #17294:
URL: https://github.com/apache/pinot/pull/17294#discussion_r2619099599
##########
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/BasePinotFS.java:
##########
@@ -36,6 +36,11 @@ public boolean deleteBatch(List<URI> segmentUris, boolean
forceDelete)
throws IOException {
boolean result = true;
for (URI segmentUri : segmentUris) {
+ // Check if file exists before attempting deletion to avoid
FileNotFoundException
+ if (!exists(segmentUri)) {
Review Comment:
Going by the `idempotent` property, successful deletion and missing file,
both should return `true`, otherwise `false`.
For the batch, if all the files are deleted or removed, return `true`
otherwise `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
